core: handle ignored error #16065
core: handle ignored error #16065
Conversation
- according to implementation of `IntrinsicGas` we can continue execution since problem will be detected later. However, early return is future-proof for changes.
|
Hm, interesting find! I think it means that if someone makes a tx with enough non-zero bytes to make the gas to over maxuint, then we'd return >>> max = (1<<64 - 1) - 21000
>>> (max // 68 ) / 1e15
135.63782407139345Btw, interesting appveyor error @karalabe: |
|
@holiman The les error is a timing issue. The test generates 32K blocks, and those are processed by the CHT/BBT processors in 4K batches with 100ms sleep in between. That sleep means that the test needs to wait for things to finish without a way to manually detect it. If CI runs slower ot schedules in a weir way, we might run out of sleep before the 100ms batches finish. I'll think about how to fix it without adding even longer timeouts. |
- according to implementation of `IntrinsicGas` we can continue execution since problem will be detected later. However, early return is future-proof for changes.
- according to implementation of `IntrinsicGas` we can continue execution since problem will be detected later. However, early return is future-proof for changes.
IntrinsicGaswe can continue execution since problem will be detected
later. However, early return is future-proof for changes.