Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use high burst value in limiter. #19176

Merged
merged 1 commit into from
Jan 13, 2025
Merged

tests: use high burst value in limiter. #19176

merged 1 commit into from
Jan 13, 2025
2 −1

Conversation

jmao-dd
Copy link
Contributor

@jmao-dd jmao-dd commented Jan 11, 2025

Use the highest MaximalQPS of all traffic profiles as burst otherwise actual traffic may be accidentally limited. For example, if burst is set to 200 it is unlikely traffic can achieve higher than 200.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@jmao-dd
tests: use high burst value in limiter.
47bd258 
Use the highest MaximalQPS of all traffic profiles as burst otherwise actual traffic may be accidentally limited.
For example, if burst is set to 200 it is unlikely traffic can achieve higher than 200.

Signed-off-by: Jiayin Mao <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmao-dd
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @jmao-dd. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jan 11, 2025

/ok-to-test

@codecov Codecov
Copy link

codecov bot commented Jan 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (75f2ae1) to head (47bd258).
Report is 20 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19176       /-   ##
==========================================
  Coverage   68.74%   68.83%    0.09%     
==========================================
  Files         420      420              
  Lines       35647    35649        2     
==========================================
  Hits        24504    24539       35     
  Misses       9713     9689      -24     
  Partials     1430     1421       -9

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f2ae1...47bd258. Read the comment docs.

@serathius
Copy link
Member

Thanks for the improvement.

@serathius serathius merged commit abf65dd into etcd-io:main Jan 13, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/robustness-testing area/testing ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmao-dd @k8s-ci-robot @ahrtr @serathius