Fix the inconsistent between listen peerURL and advertise peerURL #19136
10
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom
Root cause & solution
In test case TestMemberPromote, it sets the new learner's peerURL as
http://127.0.0.1:1234
, see below,etcd/tests/integration/clientv3/cluster_test.go
Lines 233 to 234 in fce823a
But actually the integration test framework doesn't use the peerURL specified by users at all; instead it generates a peerURL by itself, see below. This PR tries to fix the inconsistency.
etcd/tests/framework/integration/cluster.go
Lines 634 to 636 in fce823a
cc @serathius @jmhbnz @ivanvc @fuweid @siyuanfoundation