fix: use testify instead of t.Fatal or t.Error in client package (part 1) #18967
Conversation
|
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mmorel-35
force-pushed
the
testifier/client
branch
from
57ca7d7 to
92e97ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #18967 /- ##
==========================================
- Coverage 68.77% 68.74% -0.04%
==========================================
Files 420 420
Lines 35623 35623
==========================================
- Hits 24500 24489 -11
- Misses 9699 9708 9
- Partials 1424 1426 2 Continue to review full report in Codecov by Sentry.
|
mmorel-35
force-pushed
the
testifier/client
branch
from
92e97ed to
629a809
Compare
|
/ok-to-test |
mmorel-35
force-pushed
the
testifier/client
branch
3 times, most recently
from
287df21 to
1d5a9bd
Compare
|
/retest |
|
Question, @mmorel-35. How are you planning on splitting these pull requests? I want to understand it so that I can deliver a proper review :) |
|
I'm grouping PR per package/subpackage and priorizing t.Fatal replacement. |
There was a problem hiding this comment.
Thanks for the work, @mmorel-35.
I did a grep in the client directory from this branch, and it looks like there are only 24 more instances of t.Fatal after your changes. If you add them, the PR will still be less than 200 changed lines.
| @@ -23,7 23,7 @@ import ( | |||
|
|
|||
| const ( | |||
| // PrivateDirMode grants owner to make/remove files inside the directory. | |||
| PrivateDirMode = 0777 | |||
| PrivateDirMode = 0o777 | |||
There was a problem hiding this comment.
This line seems to come from the gofumpt change, not directly to testify.
There was a problem hiding this comment.
Indeed but as golangci-lint is not executed on windows platform it will never be detected in this file. Shall it be keot or reverted here ?
There was a problem hiding this comment.
I don't mind this being included, could add it as a separate commit perhaps but not a big deal.
…t 1) Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testifier/client
branch
from
1d5a9bd to
99f99cb
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This uses testify instead of testing for t.Fatal or t.Error calls in client package
Related to #18972