Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BTAdvertisedDeviceSet::toString() method output #8691

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Correctly prints the BT COD in hex without chopping the end of the number.

Related links

Closes #8684

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023

CLA assistant check
All committers have signed the CLA.

@lucasssvaz
Copy link
Collaborator Author

@esp32beans Please sign the Contributor License Agreement so I can add you as the commit author.

@esp32beans
Copy link

I do not need credit for a very small fix. I prefer to not read/sign a legal agreement unless I make a substantial contribution.

@lucasssvaz lucasssvaz force-pushed the bugfix/btad_tostring branch from 894432a to 88b6544 Compare October 3, 2023 11:54
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Oct 4, 2023
@me-no-dev me-no-dev merged commit 7b4d468 into espressif:master Oct 4, 2023
41 checks passed
@lucasssvaz lucasssvaz deleted the bugfix/btad_tostring branch March 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiscoverConnect.ino displays the incorrect value for COD (Class of Device).
5 participants