Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFi: clean up AP SSID setter & getter, support 32 chars #7941

Merged
merged 9 commits into from
May 15, 2021
Merged

WiFi: clean up AP SSID setter & getter, support 32 chars #7941

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift click to select a range
467584f
WiFi: clean up AP SSID setter / getters, support 32 chars
mcspr Mar 25, 2021
8bba2fe
upd
mcspr Apr 1, 2021
a6d0fc3
Merge remote-tracking branch 'origin/master' into wifi-ap-32
mcspr Apr 1, 2021
6351825
typo
mcspr Apr 1, 2021
4e9b19e
fixup! typo
mcspr Apr 1, 2021
3b54881
strlen cant be expected to check for null
mcspr Apr 3, 2021
e7318cb
check for sizeof instead
mcspr Apr 4, 2021
52e25cb
Merge remote-tracking branch 'origin/master' into wifi-ap-32
mcspr Apr 12, 2021
7c9b4b1
Merge branch 'master' into wifi-ap-32
earlephilhower May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
strlen cant be expected to check for null
  • Loading branch information
@mcspr
mcspr committed Apr 3, 2021
commit 3b54881b115abc0caeacf767b8878598171202ca
4 changes: 2 additions & 2 deletions libraries/ESP8266WiFi/src/ESP8266WiFiAP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 102,13 @@ bool ESP8266WiFiAPClass::softAP(const char* ssid, const char* psk, int channel,
return false;
}

size_t ssid_len = strlen(ssid);
size_t ssid_len = ssid ? strlen(ssid) : 0;
if(ssid_len == 0 || ssid_len > 32) {
DEBUG_WIFI("[AP] SSID length %u, too long or missing!\n", ssid_len);
return false;
}

size_t psk_len = strlen(psk);
size_t psk_len = psk ? strlen(psk) : 0;
if(psk_len > 0 && (psk_len > 64 || psk_len < 8)) {
DEBUG_WIFI("[AP] fail psk length %u, too long or short!\n", psk_len);
return false;
Expand Down