Fix: don't ignore the entry directory (fixes #12604) #12607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #12604
What changes did you make? (Give an overview)
This PR fixes #12604 as unignoring the entry directory.
Previously, the
eslint dir
command had checked if the directly given directory (dir
) is ignored by.eslintignore
or not. By #12274, the ignore check has gotten to load config files from the directory that thedir
exists in order to checkignorePatterns
property. As a result, theeslint .
command has gotten to try loading config files from../
. Then if config files were not found from../
and ancestors, ESLint loads personal config file.I think that it's not intuitive if the
eslint .
command checks the ignore of.
, so this PR changes that behavior. Ifeslint dir
is present anddir
is a directory, ESLint doesn't ignoredir
itself.Actually, this change has pretty small impacts. When
dir
is an ignored path, it still ignoresdir/**
even if ESLint doesn't ignoredir
itself. Therefore, the only impact is error messages ("All files matched by 'dir' are ignored" instead of "No files matching 'dir' were found") in most cases.Is there anything you'd like reviewers to focus on?