-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: bump inquirer to ^7.0.0 #12440
Conversation
Hi @josgraha, thanks for the PR! I want to test this locally tonight, then I'll approve the changes. I'll leave this open in case others want to review. |
Note to merger: Commit message needs to start with "Upgrade:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for contributing!
1b25f77
to
cc9d7e4
Compare
I'm sorry folks but I misread the Snyk Issue which only applies to |
cc9d7e4
to
643d6be
Compare
Hi @josgraha, thanks for following up. I think we can accept this upgrade anyway as it's pretty low risk, and dependency upgrades are something we sometimes struggle with here. So, I appreciate this contribution nonetheless. Thanks! |
What is the purpose of this pull request? (put an "X" next to item)
Bump
inquirer
package to^7.0.0
because 6.x depends on[email protected]
which has Snyk Issue[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Bump
inquirer
package to^7.0.0
because 6.x depends on[email protected]
which has Snyk IssueWhat changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?