-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: add --env-info flag to CLI #12270
Conversation
0982d3b
to
654d543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great in general. Thanks for putting this together!
My only thought is that I'm not sure I'm a fan of the module name info
. What info, exactly? Environment info? Rule info? Some other info? I think a name like environment-info
or runtime-info
would be a lot better even if it's a little more verbose.
|
@platinumazure Updated 😃 |
7479f90
to
86c4f5b
Compare
I've also added some regression tests with Windows-style paths. There isn't any OS-specific path handling logic yet, but thought it would be a good idea to ensure that future changes work with both styles of paths. |
1551fe2
to
86c4f5b
Compare
Hmmm the Windows tests pass locally on my Windows machine but are failing in CI. Not sure why that is - something to do with the check to see if the executing version is global or not. I've removed that commit for now and will see if I can figure out what's going on. I do think these tests are adequate. |
In the spirit of @platinumazure's comment, I'm wondering if we should actually call the flag |
bb904e1
to
21edd78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for the reviews! I'm going to go ahead and merge this. |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[x] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fixes #11958
What changes did you make? (Give an overview)
#12060 appears to have stalled, so I took some time to clean up my original proof of concept and make a PR! This feels like a win for issue triaging, since we can ask for the output of this command in our bug issue templates.
Is there anything you'd like reviewers to focus on?
Nothing in particular.