Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: add no-import-assign (fixes #12237) #12252

Merged
merged 6 commits into from
Sep 14, 2019
Merged

New: add no-import-assign (fixes #12237) #12252

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9c7cfa
New: add no-import-assign (fixes #12237)
mysticatea Sep 10, 2019
3b77e77
add destructuring and for-in/of syntax
mysticatea Sep 10, 2019
0e9f2e3
add mutation functions
mysticatea Sep 10, 2019
c20208f
add a more test
mysticatea Sep 11, 2019
d1bec8a
allow seal and preventExtensions
mysticatea Sep 11, 2019
3e25a00
add a test
mysticatea Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add a test
  • Loading branch information
@mysticatea
mysticatea committed Sep 12, 2019
commit 3e25a00398286f5f51cea27f7eecea161dbf0ea5
4 changes: 4 additions & 0 deletions tests/lib/rules/no-import-assign.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,10 @@ ruleTester.run("no-import-assign", rule, {
{
code: "import * as mod from 'mod'; Reflect.setPrototypeOf(mod, proto)",
errors: [{ messageId: "readonlyMember", data: { name: "mod" }, column: 29 }]
},
{
code: "import mod, * as mod_ns from 'mod'; mod.prop = 0; mod_ns.prop = 0",
errors: [{ messageId: "readonlyMember", data: { name: "mod_ns" }, column: 51 }]
}
]
});