Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle empty string property names in getFunctionNameWithKind #12104

Merged
merged 1 commit into from
Aug 18, 2019
Merged

Fix: Handle empty string property names in getFunctionNameWithKind #12104

merged 1 commit into from
Aug 18, 2019

Conversation

mdjermanovic
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix

Minor fix in astUtils.getFunctionNameWithKind() for empty string property names, to show '' instead of nothing in warning messages.

Tell us about your environment

  • ESLint Version: 6.1.0
  • Node Version: 10.16.0
  • npm Version: 6.9.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2018,
  },
};

What did you do? Please include the actual source code causing the issue.

An example:

/*eslint require-await: "error"*/

(class { async ''() { doSomething() } })

What did you expect to happen?

  3:10  error  Async method '' has no 'await' expression  require-await

What actually happened? Please include the actual, raw output from ESLint.

  3:10  error  Async method has no 'await' expression  require-await

What changes did you make? (Give an overview)

Explicitly check for null.

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 15, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, thanks for contributing!

Just out of curiosity, what happens with 0 or '0'? Is that affected by your change?

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features and removed triage An ESLint team member will look at this issue soon labels Aug 15, 2019
@mdjermanovic
Copy link
Member Author

Just out of curiosity, what happens with 0 or '0'? Is that affected by your change?

It shouldn't be affected because getStaticPropertyName() should return a string which would be a truthy "0" in both cases.

But to be sure that getStaticPropertyName() doesn't have the same small bug, I tried in Demo and it works well already (Async method '0' has no 'await' expression)

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants