Docs: do not recommend global-installed usage #12016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
documentation
|
I think it's fine to include those changes. Don't think they are controversial enough to warren TSC discussion. |
platinumazure
approved these changes
Jul 24, 2019
kaicataldo
approved these changes
Jul 24, 2019
|
@kaicataldo no worries, leaving it as a draft, I just want to double-check if some more background is required. but it seems pretty clear. 😄 |
|
well, I'm going to leave it open for a longer time -- to see if there is any objections from the team, and the community. |
aladdin-add
added
accepted
|
To be honest, I've always wondered why a global installation was recommended, when nearly every project I've ever worked on bundles a specific version of eslint within the package.json 😸 |
This was referenced Aug 27, 2019
This was referenced Sep 12, 2019
This was referenced Nov 9, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
do not recommend global-installed usage. this has been discussed for a long time, and seems we have done some work in this direction.
refs:
Is there anything you'd like reviewers to focus on?
seems it was not a trivial change, will it discussed in a TSC meeting?