Fix: no-extra-parens autofix with in
in a for-loop init (fixes #11706)
#11848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix: #11706
What changes did you make? (Give an overview)
In the
no-extra-parens
rule, keep parens if necessary when anin
expression is in a for-loop initializer.For example, the following will be treated as a correct code (not reported):
Removing parens would produce SyntaxError. Each line would be treated as an invalid for-in loop.
Also, this change is trying to minimize false negatives, i.e. to remove really 'extra' parens.
For example, the following:
would be fixed to:
Is there anything you'd like reviewers to focus on?