Skip to content

Commit

Permalink
chore: @eslint-community/eslint-plugin-eslint-comments v4.3.0 (#18319)
Browse files Browse the repository at this point in the history
* chore: @eslint-community/eslint-plugin-eslint-comments v4.3.0

* update comment and better sort deps
  • Loading branch information
mdjermanovic committed Apr 11, 2024
1 parent df5f8a9 commit a76fb55
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 13 deletions.
18 changes: 6 additions & 12 deletions packages/eslint-config-eslint/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 2,9 @@

const js = require("@eslint/js");
const jsdoc = require("eslint-plugin-jsdoc");
const eslintComments = require("eslint-plugin-eslint-comments");
const eslintCommentsPluginConfigs = require("@eslint-community/eslint-plugin-eslint-comments/configs");
const unicorn = require("eslint-plugin-unicorn");

/*
* the plugins' configs are not updated to support the flat config,
* need to manually update the `plugins` property
*/
eslintComments.configs.recommended.plugins = { "eslint-comments": eslintComments };

// extends eslint recommended config
const jsConfigs = [js.configs.recommended, {
rules: {
Expand Down Expand Up @@ -373,12 367,12 @@ const unicornConfigs = [{
}
}];

// extends eslint-plugin-eslint-comments's recommended config
const eslintCommentsConfigs = [eslintComments.configs.recommended, {
// extends @eslint-community/eslint-plugin-eslint-comments's recommended config
const eslintCommentsConfigs = [eslintCommentsPluginConfigs.recommended, {
rules: {
"eslint-comments/disable-enable-pair": ["error"],
"eslint-comments/no-unused-disable": "error",
"eslint-comments/require-description": "error"
"@eslint-community/eslint-comments/disable-enable-pair": ["error"],
"@eslint-community/eslint-comments/no-unused-disable": "error",
"@eslint-community/eslint-comments/require-description": "error"
}
}];

Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-eslint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 29,8 @@
"homepage": "https://eslint.org",
"bugs": "https://github.com/eslint/eslint/issues/",
"dependencies": {
"@eslint-community/eslint-plugin-eslint-comments": "^4.3.0",
"@eslint/js": "^8.42.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-jsdoc": "^46.5.1",
"eslint-plugin-n": "^17.2.0",
"eslint-plugin-unicorn": "^49.0.0"
Expand Down

0 comments on commit a76fb55

Please sign in to comment.