Remove promise duplication. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monder Good catch! The examples still work as well? |
|
The example for react-0.14 works just as before. |
Closed
|
Thanks @monder! |
|
Would be nice if you could publish a new version when you have time @ericclemmons 😃 |
|
Just published the version |
|
Great, thanks! Works like a charm. |
|
@monder What"s your Twitter name? I want to broadcast the work you"re doing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
It may not seems obvious with all stuff happening with promises in
react-routerbut methods do not mutate those.e.g.
bandcare completely different. And if the exception will be thrown inathere will be 2 unhanded ones.We should either always handle promises without breaking the chain, or wrap every split with a catch block. This PR implements the 1st option.