Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a native-image from (GraalVM) ydoc implementation #10757

Closed
hubertp opened this issue Aug 6, 2024 · 4 comments · Fixed by #10783
Closed

Create a native-image from (GraalVM) ydoc implementation #10757

hubertp opened this issue Aug 6, 2024 · 4 comments · Fixed by #10783

Comments

@hubertp
Copy link
Contributor

hubertp commented Aug 6, 2024

Since we are planning on dockering Ydoc (#10751) it seems beneficial to have an easy way to switch between NodeJS and GraalVM implementations. The latter is clearly at an disadvantage when interpreter therefore it makes sense to create a native-image for it and speedup the startup.

@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Aug 6, 2024
@hubertp hubertp moved this from ❓New to 📤 Backlog in Issues Board Aug 6, 2024
@4e6 4e6 mentioned this issue Aug 9, 2024
3 tasks
@enso-bot
Copy link

enso-bot bot commented Aug 9, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-08-08):

Progress: [10757] Added the native image build to the Ydoc SBT configuration. Removed the optional dependency to the assembly task. Debugging the failure in the parser library loading. It should be finished by 2024-08-14.

Next Day: Next day I will be working on the #10757 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Aug 10, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-08-09):

Progress: [10757] With the help of Jaroslav fixed the failure in the parser library loading. Updated the native-image config after the ydoc refactoring PR by Pavel. Fixed the resources loading in native image. Debugging the issue with type error in JS when returning the object from Java. It should be finished by 2024-08-14.

Next Day: Next day I will be working on the #10757 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Aug 13, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-08-12):

Progress: [10757] Debugging the issue with the type error in JS. Turned out that GraalVM currently does not support Virtual Threads (Project Loom) in the native image when the polyglot binding is present. The Tracking issue is oracle/graal/issues/7520. The support will be added in 24.1 release in September. It should be finished by 2024-08-14.

Next Day: Next day I will be working on the #10757 task. Continue working on the task

@4e6
Copy link
Contributor

4e6 commented Aug 16, 2024

The native image does not support virtual threads together with the Truffle languages. The #10783 reproduces the issue, and 4e6/helidon-quickstart-se provides a minified example. The support should be added in Truffle 24.1.

@4e6 4e6 added the x-on-hold label Aug 16, 2024
@mergify mergify bot closed this as completed in #10783 Oct 31, 2024
@mergify mergify bot closed this as completed in 5f52547 Oct 31, 2024
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Oct 31, 2024
MrFlashAccount pushed a commit that referenced this issue Nov 1, 2024
close #10757

Changelog:
- add: native-image configuration to the `ydoc-server` project
- add: native-image overrides for loom executors replacing them with platform threads
- update: Helidon `4.1.2`
- fix: issues related to the native-image build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

3 participants