Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sporadic No_Such_Method failure when executing Base_Tests #10750

Open
hubertp opened this issue Aug 5, 2024 · 11 comments
Open

Sporadic No_Such_Method failure when executing Base_Tests #10750

hubertp opened this issue Aug 5, 2024 · 11 comments
Assignees
@hubertp
Labels
--regression Important: regression -compiler -libs Libraries: New libraries to be implemented

Comments

@hubertp
Copy link
Contributor

hubertp commented Aug 5, 2024

The sporadic failure happens mostly on MacOS although it did appear for other OS as well.

JAVA_OPTS="-enableassertions" "/bin/bash" "/Users/runner/work/enso/enso/built-distribution/enso-engine-2024.4.1-dev-macos-amd64/enso-2024.4.1-dev/bin/enso" "--no-ir-caches" "--run" "/Users/runner/work/enso/enso/test/Base_Tests"

Will simply return a non-zero code and a simple No_Such_Method message, without any context.
The issue is not new and by looking at the past CI builds it has happened for the first time in https://github.com/enso-org/enso/actions/runs/9686658267/job/26729584788 (#10377 merge, unrelated).
@hubertp hubertp added -compiler -libs Libraries: New libraries to be implemented labels Aug 5, 2024
@enso-bot enso-bot bot mentioned this issue Aug 6, 2024
Open
@hubertp hubertp added the --regression Important: regression label Aug 6, 2024
@hubertp hubertp self-assigned this Aug 6, 2024
@radeusgd
Copy link
Member

radeusgd commented Aug 6, 2024 •
edited by unfurl-links bot
Loading

Encountered it yet again in https://github.com/enso-org/enso/actions/runs/10245645438/job/28392624237?pr=10733#step:7:2072 run

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@hubertp
Copy link
Contributor Author

hubertp commented Aug 6, 2024

This is confusing. It seems to suggest that the problem is with the test that should be pending?

@radeusgd
Copy link
Member

radeusgd commented Aug 6, 2024

This is confusing. It seems to suggest that the problem is with the test that should be pending?

What do you mean?

Do you mean the

 INFO ide_ci::program::command: bash ℹ️ Java FFI: [6/6, 17ms]
 INFO ide_ci::program::command: bash ℹ️     - [PENDING] should report missing method error on Java Arrays
 INFO ide_ci::program::command: bash ℹ️         Reason: Failing due to #6609

above?

That is most likely not it - the test summary is written after each group has finished executing. So the Java FFI pending test has finished and is now summarized.

Now the failure most likely is happening in the next group that is being executed. We could try to do a debug run which prints which group is started to try to locate the cause - but I'm not sure if that'll help.

@Akirathan
Copy link
Member

Akirathan commented Aug 6, 2024 •
edited by unfurl-links bot
Loading

Another interesting instance of this error is at https://github.com/enso-org/enso/actions/runs/10264320295/job/28398095736?pr=10555#step:7:2118 . This time, there is mention of java.io.IOException:

INFO ide_ci::program::command: bash ℹ️ java.io.IOException: No_Such_Method
GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

This was referenced Aug 6, 2024
Closed
Closed
@hubertp
Copy link
Contributor Author

hubertp commented Aug 12, 2024 •
edited
Loading

Finally.
It could be one of missing, sample, foobar, baz, nope, into, or ==. Although the exception is printed after ==.

NFO ide_ci::program::command: enso ⚠️ java.lang.RuntimeException: #10750 ==
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.runtime.builtin.Error.makeNoSuchMethod(Error.java:162)
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.node.callable.InvokeMethodNode.methodNotFound(InvokeMethodNode.java:286)
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.node.callable.InvokeMethodNode.doFunctionalDispatchUncachedSymbol(InvokeMethodNode.java:219)
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.node.callable.InvokeMethodNodeGen.execute(InvokeMethodNodeGen.java:226)
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.node.callable.InvokeCallableNode.invokeDynamicSymbol(InvokeCallableNode.java:276)
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.node.callable.InvokeCallableNodeGen.execute(InvokeCallableNodeGen.java:194)
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.node.callable.ApplicationNode.executeGeneric(ApplicationNode.java:97)
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.node.scope.AssignmentNodeGen.executeGeneric(AssignmentNodeGen.java:51)
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.node.callable.function.BlockNode.executeGeneric(BlockNode.java:52)
 INFO ide_ci::program::command: enso ⚠️ 	at org.enso.interpreter.node.ClosureRootNode.execute(ClosureRootNode.java:85)

https://github.com/enso-org/enso/actions/runs/10348083887/job/28657599636?pr=10769#step:7:10627

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@hubertp
Copy link
Contributor Author

hubertp commented Aug 13, 2024 •
edited
Loading

https://github.com/enso-org/enso/actions/runs/10358080199/job/28690409691?pr=10769#step:7:9333

Looks like this time it was == method of Error.type

@jdunkerley
Copy link
Member

Reviewed the No_Such_Method. It has the to_display_text properly set up.
I'm guessing it is an issue in engine/runtime/src/main/java/org/enso/interpreter/runtime/error/PanicException.java as to why the Java Exception is not showing the display text.

It looks like computeMessage will attempt to call the to_display_text via the InteropLibrary and fall back to the type name if it doesn't exist.

@hubertp
Copy link
Contributor Author

hubertp commented Aug 16, 2024

In my PR I've been experimenting with one revert (7bab8b8). While previously on that PR I would get sporadic failures, after applying the revert I had seen none.
Note: I don't think this change is the sole culprit of this bug. I would say that it unmasks some deeper problem, like specialization order which is triggered non-deterministically.

@JaroslavTulach
Copy link
Member

Hubert haven't seen this one for a while. Let's consider it fixed.

@hubertp hubertp reopened this Sep 3, 2024
@hubertp
Copy link
Contributor Author

hubertp commented Sep 3, 2024 •
edited by unfurl-links bot
Loading

https://github.com/enso-org/enso/actions/runs/10682796071/job/29609456166?pr=10960#step:7:3772

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@JaroslavTulach JaroslavTulach mentioned this issue Sep 10, 2024
Merged
2 tasks
@hubertp
Copy link
Contributor Author

hubertp commented Sep 10, 2024 •
edited by unfurl-links bot
Loading

And another https://github.com/enso-org/enso/actions/runs/10791389410/job/29928689658?pr=11032#step:7:1255

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hubertp hubertp

Labels
--regression Important: regression -compiler -libs Libraries: New libraries to be implemented
Projects
Issues Board
Status: ❓New
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hubertp @radeusgd @jdunkerley @Akirathan @JaroslavTulach