Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit return type with error causes type error when an error is thrown #10736

Closed
GregoryTravis opened this issue Aug 1, 2024 · 1 comment · Fixed by #10765
Closed

Explicit return type with error causes type error when an error is thrown #10736

GregoryTravis opened this issue Aug 1, 2024 · 1 comment · Fixed by #10765
Assignees
@JaroslavTulach
Labels
-compiler p-low Low priority

Comments

@GregoryTravis
Copy link
Contributor

GregoryTravis commented Aug 1, 2024 •
edited
Loading

(This bug refers to #10725)

This change to Decimal.add results in the error shown below, in the case of a thrown error:

-    add self (that : Decimal) (math_context : Math_Context | Nothing = Nothing) =
     add self (that : Decimal) (math_context : Math_Context | Nothing = Nothing) -> Decimal ! Arithmetic_Error | Illegal_Argument =

Error:

    - [FAILED] should not allow mixed arithmetic (float) [68ms]
        Reason: An unexpected panic was thrown: Type error: expected the result of `add` to be Decimal, but got <ERR>.
        at <enso> Decimal.add(/Users/gmt/dev/enso/enso/built-distribution/enso-engine-0.0.0-dev-macos-aarch64/enso-0.0.0-dev/lib/Standard/Base/0.0.0-dev/src/Data/Decimal.enso:478-482)
@JaroslavTulach
Copy link
Member

Ok. Caused by an attempt to attach warning to DataFlowError.

@JaroslavTulach JaroslavTulach mentioned this issue Aug 6, 2024
Merged
2 tasks
@enso-bot enso-bot bot mentioned this issue Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaroslavTulach JaroslavTulach

Labels
-compiler p-low Low priority
Projects
Issues Board
Status: 🟢 Accepted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attaching a warning to error is no op enso-org/enso
2 participants
@GregoryTravis @JaroslavTulach