Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Input Component #10293

Closed
1 of 2 tasks
AdRiley opened this issue Jun 15, 2024 · 10 comments · Fixed by #10774
Closed
1 of 2 tasks

Table Input Component #10293

AdRiley opened this issue Jun 15, 2024 · 10 comments · Fixed by #10774
Assignees
Labels
-gui d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints x-design x-new-feature Type: new feature request

Comments

@AdRiley
Copy link
Member

AdRiley commented Jun 15, 2024

Add the ability to create and add a table literal.
Should be editable within an ag-grid editor.
Ability to copy/paste data into the editor.

The value type should auto typed in the same way as we read CSV (i.e. ISO date/time formats and numbers in conventional form).

Tasks

  1. -gui d-intermediate p-medium x-new-feature
    Frizi
@AdRiley AdRiley added x-new-feature Type: new feature request x-design -gui labels Jun 15, 2024
@AdRiley AdRiley added this to the 2024-08 Release milestone Jun 15, 2024
@farmaazon
Copy link
Contributor

farmaazon commented Jul 5, 2024

  • The widget should match only the very specific Table.new calls (containing only proper lists with constants)
  • For now, let's hardcode call to Standard's Table.new. The designing a general way of defining such widgets spawning over entire call is a future task.
  • Let's see if AGGrid supports copypasting by default; if not, move it to a separate task.
  • The cells and columns should know their link with specific AST nodes, so any edit will make minimal change in the AST.

@farmaazon farmaazon added d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints labels Jul 5, 2024
@farmaazon farmaazon self-assigned this Jul 22, 2024
@enso-bot
Copy link

enso-bot bot commented Jul 31, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-07-30):

Progress: Debugged problems with opening projects in cloud, and reported an issue. Then, returned to table editing. Added most of the logic for adding new columns and rows, with tests. It should be finished by 2024-08-05.

Next Day: Next day I will be working on the same task. Clean-up code so the editing will work. Try to fix style of the widget and then think about renaming columns.

@enso-bot
Copy link

enso-bot bot commented Aug 1, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-07-31):

Progress: A small break for fixing doc panel scroll issues. Then continued implementation of cells edits: refactored code, handle case where the cell in the cornder is edited (so both column and row are added at once), and filling gaps in vector (like in ['a', [1, , 2]]) It should be finished by 2024-08-05.

Next Day: Next day I will be working on the same task. Remaining features.

@enso-bot
Copy link

enso-bot bot commented Aug 2, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-08-01):

Progress: Worked on table widget style; when porting the widget's style, I discovered much valuable logic, like remembering column sizes, which we wanted also in the widget, so I made a "common" table widget. Started working with custom headers to allow renaming. It should be finished by 2024-08-05.

Next Day: Next day I will be working on the same task. Finish custom headers, test a bit and see what is missing to make it at least minimally functional (and mergeable)

@enso-bot
Copy link

enso-bot bot commented Aug 2, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-08-02):

Progress: Have working custom headers, and fixed some other issues in the process It should be finished by 2024-08-07.

Next Day: Next day I will be working on the same task. Integrate the editing headers with widget (and - hopefully - grid editing) and see what remains to make a PR

@enso-bot
Copy link

enso-bot bot commented Aug 7, 2024

Adam Obuchowicz reports a new STANDUP for the last Monday (2024-08-05):

Progress: Added header renaming in our custom header. Also, unified the AGGrid usage between the widget and the visualization. Added tests. It should be finished by 2024-08-07.

Next Day: Next day I will be working on the same task. See what remains to do; handle the switching between various cell edits properly

@enso-bot
Copy link

enso-bot bot commented Aug 7, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-08-06):

Progress: Worked on proper edit handlers for both cells and headers, look at resuming edit after code change. It should be finished by 2024-08-07.

Next Day: Next day I will be working on the same task. Investigate why resuming edit does not work.

@enso-bot
Copy link

enso-bot bot commented Aug 7, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-08-07):

Progress: Finally found a proper solution for edit problem. Code cleanup, a bit of refactor, and created a PR. It should be finished by 2024-08-07.

Next Day: Next day I will be working on the #10606 task. PR comments and maybe something next.

@enso-bot
Copy link

enso-bot bot commented Aug 9, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-08-08):

Progress: The review has many comments, and some of them are non-trivial (while still necessary). Spent time mostly on proper conversions between js (and aggrids) numbers and enso numbers, proper handling of Nothing values and better widget matching mechanism. It should be finished by 2024-08-09.

Next Day: Next day I will be working on the same task. The one comment is not resolved: dynamic loading of AGGrid dependency is not yet finished.

@enso-bot
Copy link

enso-bot bot commented Aug 9, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-08-09):

Progress: Finished asynchronous AGGrid loading with Paweł's help and re-requested review It should be finished by 2024-08-09.

@mergify mergify bot closed this as completed in #10774 Aug 12, 2024
@mergify mergify bot closed this as completed in 6eece5f Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints x-design x-new-feature Type: new feature request
Projects
Status: 🗄️ Archived
Development

Successfully merging a pull request may close this issue.

2 participants