Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 6 #26

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Allow Symfony 6 #26

merged 1 commit into from
Feb 21, 2022

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Nov 24, 2021

Symfony 6 is now released.

@insign
Copy link

insign commented Jan 3, 2022

Here we are.

@ejunker
Copy link

ejunker commented Jan 22, 2022

Laravel 9 will be released on February 8, 2022 and will require version 6 of the Symfony components. Looking forward to when this PR is merged.

@jdecode
Copy link

jdecode commented Feb 14, 2022

Being a product of "enlightn", I was expecting this be one of those packages which was going to be "Laravel-9-ready" from the moment (or rather before) Laravel 9 was launched (made default).

Would love to see this happening soon... 🤞

@mglaman
Copy link

mglaman commented Feb 18, 2022

Can someone rerun the CI?

Comment on lines 30 to 33
"symfony/console": "^3.4|^4|^5|^6",
"symfony/finder": "^3|^4|^5|^6",
"symfony/process": "^3.4|^4|^5|^6",
"symfony/yaml": "^3.4|^4|^5|^6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"symfony/console": "^3.4|^4|^5|^6",
"symfony/finder": "^3|^4|^5|^6",
"symfony/process": "^3.4|^4|^5|^6",
"symfony/yaml": "^3.4|^4|^5|^6",
"symfony/console": ">=3.4",
"symfony/finder": ">=3",
"symfony/process": ">=3.4",
"symfony/yaml": ">=3.4",

Could we be more optimistic and make things more future proof?

@paras-malhotra paras-malhotra mentioned this pull request Feb 21, 2022
@paras-malhotra paras-malhotra merged commit 3e04e47 into enlightn:main Feb 21, 2022
@paras-malhotra
Copy link
Member

Thanks for the PR. This is now available in v1.10.0.

@kbond kbond deleted the sf6 branch February 21, 2022 22:46
@paras-malhotra paras-malhotra added chore Chore or maintenance task/issue enhancement New feature or request labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore or maintenance task/issue enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants