WRQ-12037: Investigate how to mock core/platform and webos/platform #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Sandstone's unit tests Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3233 /- ##
===========================================
Coverage 82.36% 82.42% 0.06%
===========================================
Files 156 156
Lines 7209 7211 2
Branches 1907 1907
===========================================
Hits 5938 8634 6
Misses 999 997 -2
Partials 272 270 -2 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Enact libraries like Sandstone have a few code to work on specific browser versions or specific platform environments but we don't test those logics in unit tests due to lack of mocking.
So we should investigate how to mock core/platform and webos/platform in unit tests
Resolution
I added an example unit test here (enactjs/sandstone#1605) to show how to mock core/platform or webos/platform.
We can mock core/platform or webos/platform by parsing "mock userAgent".
By the way, if platform information is detected once by parsing user agent, "detectedPlatform" is used after that.
We can't test multiple platform in one unit test file.
So I made "resetPlatformDescription" function to reset detected platform information.
Additional Considerations
Links
WRQ-12037
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])