Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): introduced password expiration for the Dashboard #14255

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat(dashboard): introduced password expiration for the Dashboard #14255

merged 1 commit into from
Nov 25, 2024

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Nov 20, 2024 •
edited
Loading

Fixes EMQX-13506

Release version: v/e5.9.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review November 20, 2024 14:20
@lafirest lafirest requested review from a team and JimMoen as code owners November 20, 2024 14:20
@lafirest lafirest marked this pull request as draft November 20, 2024 14:50
@lafirest lafirest force-pushed the feat/password_exp branch 2 times, most recently from da80a0c to 0a1c276 Compare November 21, 2024 03:15
@lafirest lafirest marked this pull request as ready for review November 21, 2024 09:02
@lafirest lafirest force-pushed the feat/password_exp branch 3 times, most recently from ac6e651 to 76f776e Compare November 23, 2024 07:03
zmstone
zmstone reviewed Nov 24, 2024
View reviewed changes
apps/emqx_dashboard/src/emqx_dashboard_admin.erl Outdated Show resolved Hide resolved
apps/emqx_dashboard/src/emqx_dashboard_admin.erl Outdated Show resolved Hide resolved
apps/emqx_dashboard/src/emqx_dashboard_admin.erl Outdated Show resolved Hide resolved
rel/i18n/emqx_dashboard_api.hocon Outdated Show resolved Hide resolved
@lafirest lafirest merged commit 5c70007 into emqx:master Nov 25, 2024
195 checks passed
@lafirest lafirest deleted the feat/password_exp branch November 25, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone left review comments

@HJianBo HJianBo HJianBo approved these changes

@JimMoen JimMoen Awaiting requested review from JimMoen JimMoen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lafirest @zmstone @HJianBo