fix(resource metrics): throttle resource metrics handling error message, ensure metrics when restarting or resetting metrics #14226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If for whatever reason handling a "hot" metric such as `matched` breaks, it's likely that logs will be flooded with identical messages.
…rce or resetting their metrics Fixes https://emqx.atlassian.net/browse/EMQX-13496 The reasons for the original issue that led to `emqx_metrics_worker` losing all metrics are still unknown. Here, we introduce some mitigations to avoid more drastic measures such as restarting the node.
thalesmg
force-pushed
the
20241114-r58-resource-missing-metrics
branch
from
11aeb4d
to
e0ea863
Compare
thalesmg
changed the title
|
Maybe it's action leaked in cache ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-13496
Release version: v/e5.8.3
Summary
If for whatever reason handling a "hot" metric such as
matchedbreaks, it's likely that logs will be flooded with identical messages.For still unknown reasons (e.g.:
emqx_metrics_workerprocess might die?), metricsmight be lost for a running resource, and future attempts to bump them result in
errors. As mitigation, we ensure such metrics are created here so that restarting
the resource or resetting its metrics can recreate them.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update