Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exclusive): remove deprecated table #14207

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(exclusive): remove deprecated table #14207

wants to merge 1 commit into from

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Nov 11, 2024 •
edited
Loading

Fixes EMQX-13078

Release version: v/e5.9.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review November 11, 2024 09:45
@lafirest lafirest requested a review from a team as a code owner November 11, 2024 09:45
zmstone
zmstone reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is upgrade test covered?
This also implies rolling upgrade is no longer supported from versions which uses the old table?

@lafirest
Copy link
Member Author

Is upgrade test covered? This also implies rolling upgrade is no longer supported from versions which uses the old table?

Since the previous change was introduced in e5.8.1, I think it is only safe to upgrade from e5.8.1.

@zmstone
Copy link
Member

zmstone commented Nov 16, 2024

Is upgrade test covered? This also implies rolling upgrade is no longer supported from versions which uses the old table?

Since the previous change was introduced in e5.8.1, I think it is only safe to upgrade from e5.8.1.

We'll do this in 6.0 then.

@zmstone
Copy link
Member

zmstone commented Nov 16, 2024

Is upgrade test covered? This also implies rolling upgrade is no longer supported from versions which uses the old table?

Since the previous change was introduced in e5.8.1, I think it is only safe to upgrade from e5.8.1.

We'll do this in 6.0 then.

related: #14233

@lafirest lafirest marked this pull request as draft November 20, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lafirest @zmstone