Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add Binary type #850

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Add Binary type #850

wants to merge 2 commits into from

Conversation

dmikurube
Copy link
Member

Based on #458, revising to use java.nio.ByteBuffer and to fit with the latest Embulk source tree.

@dmikurube dmikurube added this to the v0.9 milestone Nov 20, 2017
@dmikurube dmikurube mentioned this pull request Nov 20, 2017
Closed
@dmikurube
Copy link
Member Author

Memo: Changes since v0.8.10 which may conflict with the original commit :

-  embulk-core/src/main/java/org/embulk/spi/Column.java -- no change
-  embulk-core/src/main/java/org/embulk/spi/ColumnVisitor.java -- no change
-  embulk-core/src/main/java/org/embulk/spi/Page.java -- only the class JavaDoc
** embulk-core/src/main/java/org/embulk/spi/PageBuilder.java -- LARGE CHANGES
*  embulk-core/src/main/java/org/embulk/spi/PageReader.java -- only null checks
   embulk-core/src/main/java/org/embulk/spi/type/BinaryType.java -- NEW!
-  embulk-core/src/main/java/org/embulk/spi/type/TypeDeserializer.java -- no change
-  embulk-core/src/main/java/org/embulk/spi/type/Types.java -- no change
*  embulk-core/src/main/java/org/embulk/spi/util/DynamicColumnSetterFactory.java -- some changes related to deprecation
*  embulk-core/src/main/java/org/embulk/spi/util/PagePrinter.java -- deprecation
-  embulk-core/src/main/java/org/embulk/spi/util/Pages.java -- no change
*  embulk-core/src/main/java/org/embulk/spi/util/dynamic/AbstractDynamicColumnSetter.java -- deprecation
   embulk-core/src/main/java/org/embulk/spi/util/dynamic/BinaryColumnSetter.java -- NEW!
-  embulk-core/src/main/java/org/embulk/spi/util/dynamic/BooleanColumnSetter.java -- no change
-  embulk-core/src/main/java/org/embulk/spi/util/dynamic/DoubleColumnSetter.java -- no change
-  embulk-core/src/main/java/org/embulk/spi/util/dynamic/JsonColumnSetter.java -- no change
-  embulk-core/src/main/java/org/embulk/spi/util/dynamic/LongColumnSetter.java -- no change
*  embulk-core/src/main/java/org/embulk/spi/util/dynamic/SkipColumnSetter.java -- deprecation
-  embulk-core/src/main/java/org/embulk/spi/util/dynamic/StringColumnSetter.java -- no change
-  embulk-core/src/main/java/org/embulk/spi/util/dynamic/TimestampColumnSetter.java -- no change
-  embulk-core/src/test/java/org/embulk/spi/MockFormatterPlugin.java -- no change
-  embulk-core/src/test/java/org/embulk/spi/MockParserPlugin.java -- no change
-  embulk-core/src/test/java/org/embulk/spi/TestFileInputRunner.java -- no change
-  embulk-standards/src/main/java/org/embulk/standards/CsvFormatterPlugin.java -- no change
*  embulk-standards/src/main/java/org/embulk/standards/CsvParserPlugin.java -- quotes_in_quoted_fields
-  lib/embulk/column.rb -- no change
*  lib/embulk/guess/schema_guess.rb -- some changes
** lib/embulk/schema.rb -- LARGE CHANGES RELATED TO DEPRECATION

@dmikurube
Copy link
Member Author

Memo:
https://twitter.com/taroleo/status/936114307158351873
https://twitter.com/taroleo/status/936114912580878336

@dmikurube dmikurube modified the milestones: v0.9.0, v0.9.1 Jan 12, 2018
@dmikurube dmikurube modified the milestones: v0.9.1, v0.9.3 Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikurube @tomykaira