Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSO 365 Button Fill Color #292

Open
CatRP opened this issue Aug 12, 2022 · 3 comments
Open

MSO 365 Button Fill Color #292

CatRP opened this issue Aug 12, 2022 · 3 comments
Labels
bug something in the original template doesn't display correctly Issue w/ email client? potential bug in the email client

Comments

@CatRP
Copy link

CatRP commented Aug 12, 2022

Button Strokes

The button fill does not show up at all, only the stroke. This issue occurs on the desktop Microsoft 365 Outlook app for PC. They must have updated their render engine recently as I have not noticed this issue in the past.

So far I have been using a workaround fix by adding a bgcolor attribute to the button-td tag, but of course this swallows up the corner radius.

This is my first time submitting a github issue so please let me know if there is anything else you need from me.

P.S. Love the templates, the comments throughout are very informative!

@TedGoas
Copy link
Collaborator

TedGoas commented Aug 14, 2022

Hey thanks for opening your first issue, you did great :) Let's see if we can figure out what's going on together.

They must have updated their render engine recently as I have not noticed this issue in the past.

Can you tell me more about this? When did you see it working last? When did you start seeing this issue?

So far I have been using a workaround fix by adding a bgcolor attribute to the button-td tag, but of course this swallows up the corner radius.

What do you mean by this? Outlook on Windows doesn't support border-radius, so these buttons should have always been squared. Is that not the case on your end?


Unfortunately I don't have a copy of Microsoft 365 Outlook on Windows. I used Email on Acid to preview the template on Outlook Office 365 Windows 10, but but is what I see:

image

@TedGoas TedGoas added bug something in the original template doesn't display correctly Issue w/ email client? potential bug in the email client labels Aug 14, 2022
@CatRP
Copy link
Author

CatRP commented Aug 17, 2022

  • I saw this issue for the first time on August 2nd. I saw it working properly on July 20th.
  • To clarify, the Outlook button corners have always been square and continue to be square. Using the bgcolor attribute workaround removes the corner radii for other email clients. I could set up some conditional code to show a different button on Outlook vs. all other clients, but I'd consider that a last ditch resort due to the extra complexity involved.

@TedGoas
Copy link
Collaborator

TedGoas commented Aug 21, 2022

I saw this issue for the first time on August 2nd. I saw it working properly on July 20th.

Can you tell me a little about your setup? Are you using a work computer on a company network? Do you know if there was a software update around that time?

Could something have changed on your system or network, like an admin pushing a software update or changing a network rule, something out of your control and/or knowledge?

Also do you know if anyone else is experiencing this? Outside of your team?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something in the original template doesn't display correctly Issue w/ email client? potential bug in the email client
Projects
None yet
Development

No branches or pull requests

2 participants