Add num_cells variable to write_attributes() function for SGrids
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable contained a constant 1, which led to problems when writing attributes to a vtk file. The value is now calculated using the dimensions of the SGrid.
Siimeloni
force-pushed
the
Siimeloni-patch-cell-data-count
branch
from
9a78231
to
a8e2489
Compare
|
Since I will be tackling this PR from now on I just wanted to chime in and ask if there are any other changes required to get this merged. :) |
|
Nope, this great! Thank you @Siimeloni for this PR and @MrMuetze for the ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like described in this Issue, the variable
num_cellscontained a constant 1, which led to problems when writing attributes to a vtk file. The value is now calculated using the dimensions of the SGrid.The value is necessary because it is written to the line
of the vtk file, which ParaView uses to get the count of attribute values when loading a file. The value has to be equal to the cell count of the SGrid.