Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify type syntax #2310

Open
pravdomil opened this issue Sep 9, 2023 · 3 comments
Open

Clarify type syntax #2310

pravdomil opened this issue Sep 9, 2023 · 3 comments

Comments

@pravdomil
Copy link

pravdomil commented Sep 9, 2023

Since type can only define sum(or) type let's use type or keyword instead, to make it explicit.

Or maybe:

And type - zero and more values type alias
Or type - zero and more variants type or
Opaque type - basically wrapper around one value type opaque

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Thanks for reporting this! To set expectations:

  • Issues are reviewed in batches, so it can take some time to get a response.
  • Ask questions in a community forum. You will get an answer quicker that way!
  • If you experience something similar, open a new issue. We like duplicates.

Finally, please be patient with the core team. They are trying their best with limited resources.

@lue-bird
Copy link

lue-bird commented Sep 9, 2023

To me it seems somewhat confusing to call single-variant types "or":

type or Email
    = Email { local : Local, domain : Domain }

@pravdomil
Copy link
Author

that is how it works now,
it it still an or type with one variant

but that is another topic:
if or type can have only one variant

I would suggest following:

And type - zero and more values type alias
Or type - zero and more variants type or
Opaque type - basically wrapper around one value type opaque

That also solves a problem how data should be serialized into text/binary format.

Now, it is not clear if:
Or type with one variant should be treated as just the value or variant index and the value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants