-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public values are allowed to have private types #1611
Comments
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
For a example where this problem occurred: cuducos/[email protected] Thankfully, cuducos/[email protected] fixed the problem by exposing the module. |
Elm modules are currently permitted to expose values whose type signatures mention types that the module does not expose, making the types of these public values "unmentionable" by code in any other modules. For example:
Making this at least a warning would prevent two possible classes of mistakes. First of all, it would prevent the above situation of a module author forgetting to expose a type that's essential to using its public values with explicit type annotations. Second of all, it would prevent module authors from thinking they've kept a type entirely private, when in fact it's partially exposed through a public type signature.
The text was updated successfully, but these errors were encountered: