allow searching for atoms inside backticks #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the LV repo you were not able to search for atoms inside backticks, for example when searching for "validate_attrs" the corresponding option of the `Phoenix.Component.slot/3` macro could not be found. This commit fixes this by stripping the backticks from tokens and also removing trailing colons.
|
This will be great for Ash DSL docs as well, awesome 🥳 |
josevalim
reviewed
Oct 31, 2024
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the LV repo you were not able to search for atoms inside backticks, for example when searching for "validate_attrs" the corresponding option of the
Phoenix.Component.slot/3macro could not be found:This commit fixes this by stripping the backticks from tokens and also removing trailing colons. I'm not familiar with the ex_doc codebase at all, so this may very well NOT be the way to properly fix, so please double check.
After this change:
cc @josevalim