Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epub: fix fatal errors while parsing EPUB files #1854

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Jan 26, 2024

  1. epub: fix fatal errors while parsing EPUB files

    After generating the EPUB file for the Elixir docs with this version,
    and reviewing the result with `epubcheck`, I got the following summary:
    
    ```console
    $ epubcheck doc/elixir/Elixir.epub --json elixir_docs.json                                                                                                    (base)
    
    Check finished with errors
    Messages: 0 fatals / 141 errors / 0 warnings / 0 infos
    ```
    
    If you compare the previous result with what we had on #1851
    
    ```
    Messages: 9 fatals / 425 errors / 0 warnings / 0 infos
    ```
    
    you can see that now we don't have messages with `fatal` severity and we
    have reduced considerably the number of errors =)
    
    I manually checked the generated EPUB on Apple Books and the previous
    truncated sections are solved, I don't see the banner _Below is a
    rendering of the page up to the first error_ and also the links to
    anchor different anchor seems to work.
    
    Fixes: #1851
    milmazz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1d8ee00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    014d258 View commit details
    Browse the repository at this point in the history
  3. fix nav layout

    milmazz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    146388d View commit details
    Browse the repository at this point in the history