Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt parsing code blocks that don't look like modules #1662

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Don't attempt parsing code blocks that don't look like modules #1662

merged 2 commits into from
Feb 16, 2023

Conversation

wojtekmach
Copy link
Member

@wojtekmach wojtekmach commented Feb 16, 2023 •
edited
Loading

Closes #1661.

josevalim
josevalim reviewed Feb 16, 2023
View reviewed changes
lib/ex_doc/language/elixir.ex Outdated
@@ -611,10 611,14 @@ defmodule ExDoc.Language.Elixir do
end

defp parse_module(<<first>> <> _ = string, _mode) when first in ?A..?Z do
do_parse_module(string)
if string =~ ~r/[a-z0-9_] /u do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we consider . and stuff like HTML where everything is upcase?

@wojtekmach wojtekmach merged commit d00110f into main Feb 16, 2023
@wojtekmach wojtekmach deleted the wm-fix-1661 branch February 16, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codeblocks that contain ? throws a warning
2 participants
@wojtekmach @josevalim