Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove compile dependency on :preload_order MFA in has_many #4468

Merged
merged 1 commit into from
Aug 1, 2024
Merged

remove compile dependency on :preload_order MFA in has_many #4468

merged 1 commit into from
Aug 1, 2024

Conversation

Gladear
Copy link
Contributor

@Gladear Gladear commented Aug 1, 2024

Expand AST on has_many opts. This is already done on many_to_many so I figured it shouldn't cause any problem.

Fixes #4466

@josevalim josevalim merged commit 5fe6982 into elixir-ecto:master Aug 1, 2024
5 of 6 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@Gladear Gladear deleted the fix-compile-dependency-on-has-many-preload-order-mfa branch August 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:preload_order with MFA causes compile-time dependency to referenced module
2 participants