Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break apart tests for unsafe_validate_unique/3 #2909

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Break apart tests for unsafe_validate_unique/3 #2909

merged 1 commit into from
Feb 6, 2019

Conversation

nathanl
Copy link
Contributor

@nathanl nathanl commented Feb 5, 2019 •
edited
Loading

Refactor in response to #2905 (comment)

@nathanl nathanl mentioned this pull request Feb 5, 2019
Merged
nathanl
nathanl commented Feb 5, 2019
View reviewed changes
test/support/mock_repo.exs Outdated Show resolved Hide resolved
@josevalim
Copy link
Member

This is fantastic, thank you @nathanl! One comment and we should be good to go! ❤️

@nathanl
Copy link
Contributor Author

nathanl commented Feb 6, 2019

@josevalim Updated!

@josevalim josevalim merged commit 6c2bc57 into elixir-ecto:master Feb 6, 2019
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@nathanl nathanl deleted the test_refactor branch February 6, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanl @josevalim