Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call them exclusion constraints, not exclude constraints #1384

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Call them exclusion constraints, not exclude constraints #1384

merged 1 commit into from
Apr 20, 2016

Conversation

nathanl
Copy link
Contributor

@nathanl nathanl commented Apr 20, 2016

This matches the PostgreSQL docs

Per @josevalim's request in #1383

@nathanl
Copy link
Contributor Author

nathanl commented Apr 20, 2016

Note - when I do mix test.all I get a couple of errors from MIX_ENV=mysql mix test in integration_test/cases/joins.exs, but I also get those errors on master.

@josevalim josevalim merged commit d7ecccd into elixir-ecto:master Apr 20, 2016
@josevalim
Copy link
Member

Thank you!

Others have also reported the MySQL issue but we cannot reproduce it. What is your MySQL version?

@nathanl
Copy link
Contributor Author

nathanl commented Apr 21, 2016

@josevalim I opened an issue with details - #1387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nathanl @josevalim