Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room decoration: shields #2906

Closed
manuroe opened this issue Jan 15, 2020 · 2 comments · Fixed by #2962
Closed

Room decoration: shields #2906

manuroe opened this issue Jan 15, 2020 · 2 comments · Fixed by #2962
Assignees
@manuroe
Labels
feature T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Milestone
Sprint 25: Cross-...

Comments

@manuroe
Copy link
Member

manuroe commented Jan 15, 2020 •
edited
Loading

From riot-web created by dbkr: element-hq/element-web#11225

Legend in figma around: https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=2363:11

Decorate rooms with black/green/red shields as appropriate.
This decoration should only appear when the cross-signing labs flag is enabled.

(The following describes rooms in terms of users, but updating the shields on users in the UI is left to a separate issue #2905.)

  • Users
    • None: e2e off in the room
    • Black: Encryption is enabled (I don’t care about their devices)
    • Red: I’ve verified them and an unverified device exists or they were previously verified and their cross-signing identity has changed
    • Green: I’ve verified them and all of their devices are verified
  • Rooms
    • None: e2e off in the room
    • Black: Encryption is enabled
    • Red: A red user exists in the room
    • Green: All users are green
    • (The state of all users, including yourself, is considered when decorating a room)

For some additional detail, the shields are meant to layer onto the room icon in both the room list and room header:

2020-01-14 at 12 01

2020-01-14 at 12 02
This was referenced Jan 15, 2020
Closed
Closed
@manuroe manuroe mentioned this issue Jan 17, 2020
Closed
@manuroe
Copy link
Member Author

manuroe commented Jan 17, 2020

Kamino cloned this issue to vector-im/riot-ios

@SBiOSoftWhare SBiOSoftWhare self-assigned this Jan 21, 2020
@SBiOSoftWhare SBiOSoftWhare mentioned this issue Jan 22, 2020
Merged
@manuroe
Copy link
Member Author

manuroe commented Jan 24, 2020

Because of room members lazy loading, we may not have enough data to compute the right shield to display for a room. In this case, use the black shield.
In future, we will load members in background and refresh the black shield with the right one.

@jryans jryans added the story:3 label Jan 28, 2020
@manuroe manuroe assigned manuroe and unassigned SBiOSoftWhare Jan 30, 2020
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 31, 2020
@manuroe
MXRoomSummary: Add the trust property to indicate trust in other user…
6d5fcd7 
…s and devices in the room

element-hq/element-ios/issues/2906)
@manuroe manuroe mentioned this issue Jan 31, 2020
Merged
manuroe added a commit that referenced this issue Jan 31, 2020
@manuroe
Room decoration: Use shields instead of padlocks
c704526 
#2906
@manuroe manuroe mentioned this issue Jan 31, 2020
Merged
@kittykat kittykat added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
feature T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
Sprint 25: Cross-signing and e2e by d...
Development

Successfully merging a pull request may close this issue.

Room decoration: Use shields instead of padlocks element-hq/element-ios
5 participants
@kittykat @jryans @lampholder @SBiOSoftWhare @manuroe