Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark all messages as read does not work well #1425

Closed
manuroe opened this issue Aug 3, 2017 · 3 comments
Closed

Mark all messages as read does not work well #1425

manuroe opened this issue Aug 3, 2017 · 3 comments

Comments

@manuroe
Copy link
Member

manuroe commented Aug 3, 2017

After an app restart, unread messages reappear. See https://matrix.to/#/!tDRGDwZwQnlkowsjsm:matrix.org/$1501761897882825jEYhS:matrix.org
@javierquevedo
Copy link

javierquevedo commented Aug 3, 2017 •
edited
Loading

I have an issue that may be related.
If I have a session with that uses (MXFileStore [self.session setStore:store ... ] ) when calling markAllAsRead on a mxroom/mxroomsummary does not seem to work. For instance, the other end of the room do not see the marker updated to the last message after the markAllAsRead call, and the unreadcounter is not 0.

This is not the case if I do not set the store on the session.

giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Oct 19, 2017
@giomfo
Bug Fix - Mark all messages as read does not work well
c2b0170 
element-hq/element-ios#1425
@giomfo giomfo mentioned this issue Oct 19, 2017
Merged
@giomfo
Copy link
Member

giomfo commented Oct 19, 2017

@javierquevedo FYI I just fixed this issue

@giomfo giomfo closed this as completed Oct 19, 2017
@javierquevedo
Copy link

Nice, thanks for that. I was really looking forward for this fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javierquevedo @manuroe @giomfo