[ML] Update Deberta tokenizer #116358
Merged
[ML] Update Deberta tokenizer #116358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar position is correct
|
Hi @maxhniebergall, I've created a changelog YAML for you. |
|
@elasticmachine merge upstream |
|
Upon further investigation, I have determined that this initial bug fix was not causing the reported problem (although it is also a bug independently), and the problem doesn't seem to be with bytefallback. In fact, the huggingface tokenizer doesn't even produce any output for the problematic characters. |
|
Pinging @elastic/ml-core (Team:ML) |
|
@elasticmachine merge upstream |
maxhniebergall
added
the
auto-backport
This was referenced Nov 20, 2024
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Nov 20, 2024
* Was using byte position for end of offset, but it seems like using char position is correct * Update docs/changelog/116358.yaml * Update UnigramTokenizer.java --------- Co-authored-by: Elastic Machine <[email protected]>
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Nov 20, 2024
* Was using byte position for end of offset, but it seems like using char position is correct * Update docs/changelog/116358.yaml * Update UnigramTokenizer.java --------- Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Was using byte position for end of offset, but it seems like using char position is correct * Update docs/changelog/116358.yaml * Update UnigramTokenizer.java --------- Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Was using byte position for end of offset, but it seems like using char position is correct * Update docs/changelog/116358.yaml * Update UnigramTokenizer.java --------- Co-authored-by: Elastic Machine <[email protected]>
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
* Was using byte position for end of offset, but it seems like using char position is correct * Update docs/changelog/116358.yaml * Update UnigramTokenizer.java --------- Co-authored-by: Elastic Machine <[email protected]>
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
* Was using byte position for end of offset, but it seems like using char position is correct * Update docs/changelog/116358.yaml * Update UnigramTokenizer.java --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using byte position, but the other code uses char position, so we should probably do that.