Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmute ValuesTests and reduce strings memory usage #111455

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Unmute ValuesTests and reduce strings memory usage #111455

merged 3 commits into from
Jul 31, 2024

Conversation

ivancea
Copy link
Contributor

@ivancea ivancea commented Jul 30, 2024 •
edited
Loading

Strings tests were taking too much memory in the worst cases. And VALUES() store all the values.

Fixes #111428
Fixes #111429

@ivancea ivancea added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL labels Jul 30, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

not-napoleon
not-napoleon approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivancea ivancea added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 31, 2024
@elasticsearchmachine elasticsearchmachine merged commit 1837133 into elastic:main Jul 31, 2024
15 checks passed
@ivancea ivancea deleted the unmute-values-tests branch July 31, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-napoleon not-napoleon not-napoleon approved these changes

@nik9500 nik9500 Awaiting requested review from nik9500

@fang-xing-esql fang-xing-esql Awaiting requested review from fang-xing-esql

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.16.0
Projects
None yet
Milestone
No milestone
3 participants
@ivancea @elasticsearchmachine @not-napoleon