Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Tuning] Accepted Default Telnet Port Connection #3954

Merged
merged 2 commits into from
Aug 3, 2024
Merged

[Rule Tuning] Accepted Default Telnet Port Connection #3954

merged 2 commits into from
Aug 3, 2024

Conversation

w0rk3r
Copy link
Contributor

@w0rk3r w0rk3r commented Aug 2, 2024

Issues

Resolves #3264

Summary

Adds flow_denied to the exclusion list.

@protectionsmachine
Copy link
Collaborator

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@w0rk3r w0rk3r merged commit fbaac66 into main Aug 3, 2024
9 checks passed
@w0rk3r w0rk3r deleted the rt_003 branch August 3, 2024 23:15
protectionsmachine pushed a commit that referenced this pull request Aug 3, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit fbaac66)
protectionsmachine pushed a commit that referenced this pull request Aug 3, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit fbaac66)
protectionsmachine pushed a commit that referenced this pull request Aug 3, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit fbaac66)
protectionsmachine pushed a commit that referenced this pull request Aug 3, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit fbaac66)
protectionsmachine pushed a commit that referenced this pull request Aug 3, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit fbaac66)
protectionsmachine pushed a commit that referenced this pull request Aug 3, 2024
Co-authored-by: Mika Ayenson <[email protected]>

(cherry picked from commit fbaac66)
eric-forte-elastic added a commit that referenced this pull request Aug 5, 2024
* [New Rule] AWS IAM CompromisedKeyQuarantine Policy Attached to User (#3910)

* [New Rule] AWS IAM CompromisedKeyQuarantine Policy Attached to User

* increased severity score

Co-authored-by: Ruben Groenewoud <78494512 [email protected]>

---------

Co-authored-by: Ruben Groenewoud <78494512 [email protected]>

* [Rule Tuning] System Binary Moved or Copied (#3933)

* [Rule Tuning] Sensitive Registry Hive Access via RegBack (#3947)

Co-authored-by: Mika Ayenson <[email protected]>

* [New Rule] Potential Relay Attack against a Domain Controller (#3928)

* [New Rule] Potential Relay Attack against a Domain Controller

* Update credential_access_dollar_account_relay.toml

* Move to the correct folder

* [Rule Tuning] AWS S3 Object Versioning Suspended (#3953)

* [Tuning] Executable Bit Set for Potential Persistence Script (#3929)

* [Rule Tuning] Microsoft IIS Service Account Password Dumped (#3935)

* [Rule Tuning] Accepted Default Telnet Port Connection (#3954)

Co-authored-by: Mika Ayenson <[email protected]>

* ndjson support for action connectors

* Add kibana API support for actions

* Minor typo

* Add actions connector support

* update rule formatter

* Fix typo

* [New Rule] Outlook Home Page Registry Modification (#3946)

* Fix typos

* Update docs and generated config

* Update all_versions

* Fix comments

---------

Co-authored-by: Isai <59296946 [email protected]>
Co-authored-by: Ruben Groenewoud <78494512 [email protected]>
Co-authored-by: Jonhnathan <26856693 [email protected]>
Co-authored-by: Mika Ayenson <[email protected]>
zsohamwag pushed a commit to zsohamwag/zsoham-detection-rules that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto Domain: Network Rule: Tuning tweaking or tuning an existing rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] flow_denied missing in "Accepted Default Telnet Port Connection" SIEM rule query
4 participants