Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react_sync_rta_updates_3783 #3938

Merged
merged 3 commits into from
Aug 8, 2024
Merged

react_sync_rta_updates_3783 #3938

merged 3 commits into from
Aug 8, 2024

Conversation

protectionsmachine
Copy link
Collaborator

RTA files updated from REACT

@botelastic botelastic bot added the RTA work on RTA framework label Aug 1, 2024
@shashank-elastic shashank-elastic self-assigned this Aug 8, 2024
@shashank-elastic shashank-elastic added the enhancement New feature or request label Aug 8, 2024
@protectionsmachine
Copy link
Collaborator Author

Enhancement - Guidelines

These guidelines serve as a reminder set of considerations when addressing adding a feature to the code.

Documentation and Context

  • Describe the feature enhancement in detail (alternative solutions, description of the solution, etc.) if not already documented in an issue.
  • Include additional context or screenshots.
  • Ensure the enhancement includes necessary updates to the documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Code changes do not introduce new warnings or errors.
  • Variables and functions are well-named and descriptive.
  • Any unnecessary / commented-out code is removed.
  • Ensure that the code is modular and reusable where applicable.
  • Check for proper exception handling and messaging.

Testing

  • New unit tests have been added to cover the enhancement.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and validating the enhancement (e.g., test logs, screenshots).
  • Validate that any rules affected by the enhancement are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.

Additional Checks

  • Ensure that the enhancement does not break existing functionality.
  • Review the enhancement with a peer or team member for additional insights.
  • Verify that the enhancement works across all relevant environments (e.g., different OS versions).
  • Confirm that all dependencies are up-to-date and compatible with the changes.

@shashank-elastic shashank-elastic merged commit f47053b into main Aug 8, 2024
9 checks passed
@shashank-elastic shashank-elastic deleted the react_sync_rta_3783 branch August 8, 2024 14:03
protectionsmachine added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: shashank-elastic <91139415 [email protected]>

(cherry picked from commit f47053b)
protectionsmachine added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: shashank-elastic <91139415 [email protected]>

(cherry picked from commit f47053b)
protectionsmachine added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: shashank-elastic <91139415 [email protected]>

(cherry picked from commit f47053b)
protectionsmachine added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: shashank-elastic <91139415 [email protected]>

(cherry picked from commit f47053b)
protectionsmachine added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: shashank-elastic <91139415 [email protected]>

(cherry picked from commit f47053b)
protectionsmachine added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: shashank-elastic <91139415 [email protected]>

(cherry picked from commit f47053b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto enhancement New feature or request RTA work on RTA framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants