Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests #2

Open
elast0ny opened this issue Dec 22, 2020 · 1 comment
Open

Write tests #2

elast0ny opened this issue Dec 22, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@elast0ny
Copy link
Owner

simple_parse relies on automatically generated code and unsafe implementations that have been manually validated to be safe.

It would provide an extra sense of "security" if we also had tests testing a bunch of different edge cases e.g. :

  • Invalid lengths (Too short, too big)
  • Invalid contents (Bad utf8 for strings, 0 for NonZero, etc...)
  • Invalid alignment for references
  • Etc...

This will be a pain to write manually so macros will probably have to be create to test each default implementation and then test the derived code containing those default impls

@elast0ny elast0ny added enhancement New feature or request good first issue Good for newcomers labels Dec 23, 2020
@elast0ny
Copy link
Owner Author

Started writing basic tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant