[serapi] New command SaveDoc to save .vo files.
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the experimental character of this PR as TTBOMK the corresponding upstream path for saving interactive files has not been tested. It seems to work OK in my own testing tho, .vo files generated by coqc and |
ejgallego
force-pushed
the
v8.13 save_vo
branch
2 times, most recently
from
b2834b0
to
7d4cb6b
Compare
|
@JasonGross let me know if you would like to test / review this, otherwise I will proceed to merge. |
We introduce a new commmand: ```lisp (SaveDoc opts) ``` to save .vo files from an interactive session. `opts` are optional, and can be - `(sid s)`: save the document at a specific sentence - `(prefix_output_dir dir)` add a prefix to the `file.vo` to be saved. Note that Coq requires that the module name and the filename do match, thus in order to use this command `sertop` must be called with the `--topfile file.v` flag, otherwise `CannotSaveVo` will be raised. Closes #128 #238
ejgallego
force-pushed
the
v8.13 save_vo
branch
from
7d4cb6b
to
3fae750
Compare
|
I would suggest merging, as my only current plan for using this feature is via @cpitclaudel 's Alectryon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a new commmand:
to save .vo files from an interactive session.
optsare optional,and can be
(sid s): save the document at a specific sentence(prefix_output_dir dir)add a prefix to thefile.voto be saved.Note that Coq requires that the module name and the filename do match,
thus in order to use this command
sertopmust be called with the--topfile file.vflag, otherwiseCannotSaveVowill be raised.Closes #128 closes #238