Fix preset saving #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great extension, I really enjoy it. I was also noticing the bug described in #48, but haven't really had a chance to dig into it until now. I found that unfortunately the call to
chrome.storage.sync.setafter theswitchwas getting called asynchronously before a particular case block was completed. This would effectively make it seem like nothing was being save/changed, because it thesetwas happening before the change took place.This solution was the best one I came up with so far, and it seems to work. I'm happy to refactor it a different way if you would like, or implement any other suggestions you might have.