GitHub-278 - hasSimplifiedMolecularInputLineEntrySpecification is misleading and inconsistent #416
Conversation
…putLineEntry to SMILES and deprecated the originals throughout Signed-off-by: Elisa Kendall <[email protected]>
Signed-off-by: Elisa Kendall <[email protected]>
| <rdfs:label>amlodipine besylate simplified molecular input line entry</rdfs:label> | ||
| <cmns-txt:hasTextValue>OS(=O)(=O)C1=CC=CC=C1.CCOC(=O)C2=C(COCCN)NC(C)=C(C2C3=C(Cl)C=CC=C3)C(=O)OC</cmns-txt:hasTextValue> | ||
| <idmp-sub:hasSMILESValue>OS(=O)(=O)C1=CC=CC=C1.CCOC(=O)C2=C(COCCN)NC(C)=C(C2C3=C(Cl)C=CC=C3)C(=O)OC</idmp-sub:hasSMILESValue> |
There was a problem hiding this comment.
Why do we need "has SMILES Value" and cannot just reuse the previous hasTextValue?
There was a problem hiding this comment.
@Heiner-Oberkampf It was there before, but not used in the examples .... but it had the long name that Thomas and others objected to
| <owl:Class rdf:about="&idmp-sub;SimplifiedMolecularInputLineEntry"> | ||
| <owl:deprecated rdf:datatype="&xsd;boolean">true</owl:deprecated> | ||
| <owl:equivalentClass rdf:resource="&idmp-sub;SMILES"/> | ||
| </owl:Class> |
There was a problem hiding this comment.
Is owl:equivalentClass and below the owl:equivalentProperty really the right link from a deprecated resource? From my understanding this would mean that the URIs are treated as equal and that would deprecate the replacement as well.
Could we maybe better use http://purl.org/dc/terms/isReplacedBy ?
There was a problem hiding this comment.
@Heiner-Oberkampf This approach is widely used for dealing with deprecated elements, and is considered a best practice. The equivalences will be removed when we eliminate the deprecated elements eventually. The Dublin Core property does not have any semantics associated with it, whereas use of equivalences allows folks to take advantage of the semantics that the old class/property had in their applications.
Description: Changed the class and property for SimplifiedMolecularInputLineEntry to SMILES and deprecated the originals throughout per SME request