Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDMP-528 - The definition of physical substance in the ISO 11238 ontology should correspond to the precise wording from paragraph 3.84 #351

Merged
merged 4 commits into from
May 3, 2023

Conversation

ElisaKendall
Copy link
Contributor

@ElisaKendall ElisaKendall commented May 1, 2023

Description: Revised the substances definitions of physical manufactured item and physical substance to add annotations stating that they are extensions of the ISO 11238 standard and thus their definitions do not need to conform precisely to the wording in the standard.

Signed-off-by: Elisa Kendall [email protected]

…d item and physical substance to reflect the precise wording from ISO 11238

Signed-off-by: Elisa Kendall <[email protected]>
@ElisaKendall ElisaKendall added bug Something isn't working metadata This label is for issues/prs that have to with the metadata ontologies needed for IDMP. labels May 1, 2023
@ElisaKendall ElisaKendall self-assigned this May 1, 2023
@@ -1112,8 1112,9 @@
</rdfs:subClassOf>
<rdfs:label>physical manufactured item</rdfs:label>
<dct:source>ISO 11238:2018 Health informatics - Identification of medicinal products (IDMP) - Data elements and structures for the unique identification and exchange of regulated information on substances, clause 3.38</dct:source>
<skos:definition>good that embodies the qualitative and quantitative composition of a product as contained in the packaging of the medicinal product</skos:definition>
<skos:definition>qualitative and quantitative composition of a product as contained in the packaging of the medicinal product</skos:definition>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the definition for the specification of the manufactured item. It is wrong or at least very misleading as definition of the physical manufactured item. Note that we have the product constituency which would better fit this definition.

@ElisaKendall
Copy link
Contributor Author

@tw-osthus Amgen specifically requested that we change the definition for this element to the language from the specification though. So if the definition was more appropriate as we had it, we will need to explain fully to Amgen.

@tw-osthus
Copy link
Contributor

Amgen needs to understand the difference between the physical manufactured item and the manufactured item. The physical manufactured item is only an interface for an IDMP specification to the inventory or a specific case or study, where the physical MI is used. Changing the definition to something, that does not match the formal definitions (class hierarchy and restrictions) is an error that must be fixed.

The PMI is a product, and it embodies a composition, but it is not a composition. That would be a dependent quality/characteristic of the independent physical thing, that is packaged innermost in the PMP, so the definition is wrong.

…to the original but retained the annotation stating that it is an extension of the ISO standard

Signed-off-by: Elisa Kendall <[email protected]>
@ElisaKendall
Copy link
Contributor Author

@tw-osthus After discussion with Heiner earlier today, we agreed that the original definition was fine and ensured that there is an annotation stating that physical manufactured item is specifically an extension to the standard. This way we can defend the fact that the definition isn't identical to the original.

…into IDMP-528 and addressed conflicts

Signed-off-by: Elisa Kendall <[email protected]>
tw-osthus
tw-osthus previously approved these changes May 3, 2023
…-528

Signed-off-by: Elisa Kendall <[email protected]>

# Conflicts:
#	ISO/ISO11238-Substances.rdf
Copy link
Contributor

@Heiner-Oberkampf Heiner-Oberkampf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed with Elisa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metadata This label is for issues/prs that have to with the metadata ontologies needed for IDMP. UC1 Active Moiety – Clinical Use Case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants