Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDMP-393 & IDMP-408: Add SPOR RMS Transformation #286

Merged
merged 12 commits into from
Feb 10, 2023
Merged

IDMP-393 & IDMP-408: Add SPOR RMS Transformation #286

merged 12 commits into from
Feb 10, 2023

Conversation

aliariff
Copy link
Contributor

Signed-off-by: Ali Ariff [email protected]

@aliariff
Copy link
Contributor Author

Hi @mereolog

I don't see existing Label that fit for PR like this, any suggestion?

@mereolog
Copy link
Contributor

Hi @mereolog

I don't see existing Label that fit for PR like this, any suggestion?

I added 'reference data'.

Heiner-Oberkampf
Heiner-Oberkampf previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Heiner-Oberkampf Heiner-Oberkampf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed result files and verified that initial feedback is incorporated

mereolog
mereolog reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@mereolog mereolog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we do import to SKOS?
This will make comparison to IDMP Ontology more difficult.

@Heiner-Oberkampf
Copy link
Contributor

Why do we do import to SKOS? This will make comparison to IDMP Ontology more difficult.

For simplicity we use some annotation properties from SKOS and skos:broader for hierarchies as the hierarchies in SPOR RMS are not all proper rdfs:subClassOf relationships.

All RMS is subject to revision as it gets properly aligned to the IDMP-O. So there is no direct hard commitment to import SKOS per se.

mereolog
mereolog reviewed Jan 25, 2023
View reviewed changes
etc/transformation/SPOR/referentials/spor-referentials.rqg
AS ?Spor_Domain_URI )

BIND(
IF(?Status = "CURRENT", <https://spor.ema.europa.eu/rmswi/#/lists/200000005003/terms/200000005004>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: #293 (comment).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mereolog I updated the description for the RMS transformation as discussed in yesterdays weekly. Ali will now update the transformation script accordingly. If we later want to get from SKOS-XL to some OMG standard this can be done later. For now SKOS-XL is the simplest option - also for use in pharma internal systems

Heiner-Oberkampf
Heiner-Oberkampf approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@Heiner-Oberkampf Heiner-Oberkampf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed results in Accurids

@aliariff aliariff changed the title IDMP-393: Add SPOR RMS Transformation IDMP-393 & IDMP-408: Add SPOR RMS Transformation Feb 9, 2023
@mereolog mereolog merged commit 6ac90a4 into master Feb 10, 2023
@mereolog mereolog deleted the IDMP-393 branch February 10, 2023 15:01
@mereolog mereolog added this to the Release 0.3.0 milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mereolog mereolog mereolog approved these changes

@Heiner-Oberkampf Heiner-Oberkampf Heiner-Oberkampf approved these changes

@ElisaKendall ElisaKendall Awaiting requested review from ElisaKendall

Assignees
No one assigned
Labels
reference data
Projects
None yet
Milestone
Release 0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aliariff @mereolog @Heiner-Oberkampf