Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: fix equality checks for manifest properties #777

Merged
merged 2 commits into from
Dec 16, 2024
Merged

coordinator: fix equality checks for manifest properties #777

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift click to select a range
9d0a0d8
fix DisableSecretBinding ignored in Marble.Equal
thomasten Dec 10, 2024
0607107
fix AcceptedTCBStatuses and AcceptedAdvisories ignored in PackageProp…
daniel-weisse Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix DisableSecretBinding ignored in Marble.Equal
  • Loading branch information
@thomasten @daniel-weisse
thomasten authored and daniel-weisse committed Dec 13, 2024
commit 9d0a0d8f73d6901bedf449d1c9d6db40849a5ada
3 changes: 2 additions & 1 deletion coordinator/manifest/manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 113,8 @@ func (m Marble) Equal(other Marble) bool {

return m.Package == other.Package &&
m.MaxActivations == other.MaxActivations &&
m.Parameters.Equal(other.Parameters)
m.Parameters.Equal(other.Parameters) &&
m.DisableSecretBinding == other.DisableSecretBinding
}

// Parameters contains lists for files, environment variables and commandline arguments that should be passed to an application.
Expand Down