Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpServer close handler not invoked if actual server is null #2868

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

tsegismont
Copy link
Contributor

Fixes #2867

@tsegismont
Copy link
Contributor Author

@vietj can you please review? I set the issue milestone to 3.7, if you're fine with backporting.

Copy link
Member

@vietj vietj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change

@vietj
Copy link
Member

vietj commented Mar 6, 2019 via email

…al server is null

Signed-off-by: Thomas Segismont <[email protected]>
@tsegismont tsegismont merged commit 19120a6 into eclipse-vertx:master Mar 6, 2019
@pmlopes pmlopes removed the to review label Mar 6, 2019
@tsegismont tsegismont deleted the issue/2867 branch March 6, 2019 09:33
tsegismont added a commit that referenced this pull request Mar 6, 2019
@tsegismont tsegismont self-assigned this Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants