Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated method from Updatable interface #3188

Closed
arman-yekkehkhani opened this issue Jun 21, 2024 · 3 comments · Fixed by #3355
Closed

Replace deprecated method from Updatable interface #3188

arman-yekkehkhani opened this issue Jun 21, 2024 · 3 comments · Fixed by #3355
Assignees
@abusk
Labels
bug Something isn't working
Milestone
1.18.0

Comments

@arman-yekkehkhani
Copy link
Contributor

Component

None

Task description

Description

Method Updatable.replace is used in several places in the project. However, the method is deprecated, and Javadoc advises using the method update instead. The reason behind it is explained in alternatives-to-createOrReplace-and-replace.
@manusa
Copy link
Member

manusa commented Jun 25, 2024

We should start by listing the places where this method is used and then evaluate the strategy to replace it one by one (edit, update, and so on).

@manusa manusa added the bug Something isn't working label Jun 25, 2024
@arman-yekkehkhani
Copy link
Contributor Author

@manusa Thanks! I searched through the project and found out that this method was only used in method updateImageName of class DockerImageWatcher. There were a few test cases in DockerImageWatcherRestartContainerTest that used it also.

@abusk
Copy link
Contributor

abusk commented Sep 2, 2024

@manusa please assign it to me.

@abusk abusk mentioned this issue Sep 2, 2024
Merged
17 tasks
@manusa manusa added this to the 1.18.0 milestone Sep 6, 2024 — with automated-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abusk abusk

Labels
bug Something isn't working
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

fix: Replace deprecated method from Updatable interface abusk/jkube
3 participants
@manusa @abusk @arman-yekkehkhani